Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize the API with Omni Token. #252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Synchronize the API with Omni Token. #252

wants to merge 4 commits into from
+115 −21

Conversation

olga24912
Copy link
Contributor

@olga24912 olga24912 commented Jan 22, 2025 •
edited
Loading

Omni Token: https://github.com/Near-One/omni-bridge/blob/main/near/omni-token/src/lib.rs

It is planned to use the Bridge Token in Omni Bridge. To make this possible:

  1. Added a function that sets a new controller in tokens. For the controller to be updated, confirmation from the new controller is required.
  2. Changed the API for mint. Now, ft_transfer_call is executed inside mint to be compatible with the functionality in OmniToken.
  3. Added the sender_id field to finish_withdraw to support a similar interface in OmniBridge without changing the token functionality related to the withdraw call.

Related PR: Near-One/omni-bridge#203

This was referenced Jan 23, 2025
Open
Open
@olga24912 olga24912 marked this pull request as ready for review January 30, 2025 18:35
@olga24912 olga24912 requested a review from karim-en as a code owner January 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karim-en karim-en Awaiting requested review from karim-en karim-en is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olga24912